Updates required to run SNAPRed #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNAPRed seems to require a later build of mantidworkbench to run, otherwise I get an exception:
File ".../SNAPRed/src/snapred/backend/recipe/algorithm/RemoveEventBackground.py", line 14, in <module>
from mantid.simpleapi import (
ImportError: cannot import name 'GroupedDetectorIDs' from 'mantid.simpleapi' (.../anaconda3/envs/SNAPRed/lib/python3.10/site-packages/mantid/simpleapi.py)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #513 +/- ##
==========================================
+ Coverage 95.65% 96.58% +0.93%
==========================================
Files 67 67
Lines 5012 5012
==========================================
+ Hits 4794 4841 +47
+ Misses 218 171 -47 ☔ View full report in Codecov by Sentry. |
rboston628
previously approved these changes
Dec 5, 2024
rboston628
approved these changes
Dec 5, 2024
rboston628
added a commit
that referenced
this pull request
Dec 6, 2024
SNAPRed seems to require a later build of mantidworkbench to run, otherwise I get an exception:
File ".../SNAPRed/src/snapred/backend/recipe/algorithm/RemoveEventBackground.py", line 14, in <module>
from mantid.simpleapi import (
ImportError: cannot import name 'GroupedDetectorIDs' from 'mantid.simpleapi' (.../anaconda3/envs/SNAPRed/lib/python3.10/site-packages/mantid/simpleapi.py)
Co-authored-by: Reece Boston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNAPRed seems to require a later build of mantidworkbench to run, otherwise I get an exception: